Code Review

Created

Created

2020 Jul 22 1:5

Creator

Creator

Seonglae Cho

Editor

Editor

Seonglae Cho

Edited

Edited

2024 May 21 12:37

Refs

Refs

훈수가 더 깐깐하다 보니, 코드 퀄리티를 위해서 리드의 훈수는 꼭 필요하다

Code Review 하지만 그러기 위해서 리드는 개발하지 않더라도 훈수둘 실력이 있어야함

파일별 담당자 체크 전부 하고 merge

질문한 사람이 resolve

수정 제안
정보 질문
이유 질문

Code Review Methods

Mob Code Review

Nudge Code Review

Google Critique & Gerrit (open-sourced)

How Google does code review

Google has two internal code review tools: Critique, which is used by the majority of engineers, and Gerrit, which is open-sourced and continues to be used by public-facing projects. Here's how they work.

How Google does code review

https://graphite.dev/blog/how-google-does-code-review

How Google does code review

How Google takes the pain out of code reviews, with 97% dev satisfaction

A study of Google's code review tooling (Critique), AI-powered improvements, and recent statistics

How Google takes the pain out of code reviews, with 97% dev satisfaction

https://engineercodex.substack.com/p/how-google-takes-the-pain-out-of

How Google takes the pain out of code reviews, with 97% dev satisfaction

With Git

Post-Commit Reviews

I recently read an excellent article in the Amazon Builder's Library by Clare Liguori which goes into great detail about AWS's CI/CD architecture. It's a truly brilliant post and I recommend everyone interested in CI/CD infrastructures read the article. The article covers the gamut from unit testing to integration testing (in production) to staged rollouts in "waves" to automated rollbacks.

Post-Commit Reviews

https://medium.com/@copyconstruct/post-commit-reviews-b4cc2163ac7a

Post-Commit Reviews

Recommendations

/////